Add a helper for stopping pods and containers in E2E #21671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a lot of boilerplate, but also ensures that every stop test that is not directly testing podman stop or podman pod stop uses `-t0` for quick, error-free stopping. Signed-off-by: Matt Heon <[email protected]>
openshift-ci
bot
added
release-note-none
approved
|
@edsantiago PTAL, I think this will help a bit with #20196 |
|
LGTM, nice fix. |
edsantiago
approved these changes
Feb 15, 2024
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c84bb81
into
containers:main
74 of 91 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of boilerplate, but also ensures that every stop test that is not directly testing podman stop or podman pod stop uses
-t0for quick, error-free stopping.Does this PR introduce a user-facing change?