-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable windows and PM windows testing #21564
Merged
openshift-merge-bot
merged 2 commits into
containers:main
from
cevich:enforcing_win_tests_again
Feb 13, 2024
Merged
Enable windows and PM windows testing #21564
openshift-merge-bot
merged 2 commits into
containers:main
from
cevich:enforcing_win_tests_again
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
release-note-none
labels
Feb 8, 2024
cevich
force-pushed
the
enforcing_win_tests_again
branch
from
February 8, 2024 14:53
a001f3f
to
f3fcffb
Compare
cevich
force-pushed
the
enforcing_win_tests_again
branch
from
February 8, 2024 15:14
f3fcffb
to
fb7aaa3
Compare
cevich
force-pushed
the
enforcing_win_tests_again
branch
from
February 8, 2024 21:56
fb7aaa3
to
f35accb
Compare
cevich
force-pushed
the
enforcing_win_tests_again
branch
from
February 12, 2024 14:30
f35accb
to
b55aef6
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Feb 12, 2024
Merged
cevich
force-pushed
the
enforcing_win_tests_again
branch
from
February 12, 2024 15:21
b55aef6
to
16b6e2d
Compare
cevich
force-pushed
the
enforcing_win_tests_again
branch
from
February 13, 2024 14:53
16b6e2d
to
c220be5
Compare
When dealing with environment variables that set $HOME, we do not get the desired result. Windows will honor USERPROFILE. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
**Depends on:** - containers#21551 - containers#21562 Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
enforcing_win_tests_again
branch
from
February 13, 2024 19:27
c220be5
to
464638c
Compare
/approve |
openshift-ci
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 13, 2024
baude
approved these changes
Feb 13, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
cevich
added a commit
to cevich/podman
that referenced
this pull request
Feb 13, 2024
**Depends on:** - containers#21551 - containers#21562 - containers#21564 Signed-off-by: Chris Evich <[email protected]>
stale-locking-app
bot
added
the
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
label
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
lgtm
Indicates that a PR is ready to be merged.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
machine
release-note-none
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Does this PR introduce a user-facing change?