Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable windows and PM windows testing #21564

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Feb 8, 2024

Depends on:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Feb 8, 2024
@cevich cevich force-pushed the enforcing_win_tests_again branch from a001f3f to f3fcffb Compare February 8, 2024 14:53
@cevich cevich force-pushed the enforcing_win_tests_again branch from f3fcffb to fb7aaa3 Compare February 8, 2024 15:14
@cevich cevich force-pushed the enforcing_win_tests_again branch from fb7aaa3 to f35accb Compare February 8, 2024 21:56
@cevich cevich force-pushed the enforcing_win_tests_again branch from f35accb to b55aef6 Compare February 12, 2024 14:30
@cevich cevich marked this pull request as ready for review February 12, 2024 14:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2024
@cevich cevich mentioned this pull request Feb 12, 2024
@cevich cevich requested a review from baude February 12, 2024 15:19
@cevich cevich force-pushed the enforcing_win_tests_again branch from b55aef6 to 16b6e2d Compare February 12, 2024 15:21
@cevich cevich force-pushed the enforcing_win_tests_again branch from 16b6e2d to c220be5 Compare February 13, 2024 14:53
baude and others added 2 commits February 13, 2024 13:20
When dealing with environment variables that set $HOME, we do not get
the desired result.  Windows will honor USERPROFILE.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@cevich cevich force-pushed the enforcing_win_tests_again branch from c220be5 to 464638c Compare February 13, 2024 19:27
@baude
Copy link
Member

baude commented Feb 13, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, cevich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member

baude commented Feb 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 07779e0 into containers:main Feb 13, 2024
88 checks passed
cevich added a commit to cevich/podman that referenced this pull request Feb 13, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 14, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants