-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed podman-mac-helper uninstall
to remove docker.sock symlink
#21499
Fixed podman-mac-helper uninstall
to remove docker.sock symlink
#21499
Conversation
@baude @ashley-cui @n1hility PTAL |
2c6b4f6
to
021713c
Compare
@tnk4on Yes that looks good, but can you use: Rather then The errors.Is it the new way to handle this. |
021713c
to
d569d7c
Compare
LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, tnk4on The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d569d7c
to
71b52bb
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
LGTM once CI passes |
71b52bb
to
6a9e41e
Compare
Signed-off-by: Shion Tanaka <[email protected]>
6a9e41e
to
bd0a9e9
Compare
CI still has errors. Do I need to retry? |
Changes LGTM |
/lgtm |
6c7f987
into
containers:main
Fixed to remove not only plist but also
/var/run/docker.sock
(symlink) whenpodman-mac-helper uninstall
command is executed.Fix: #20650 and podman-desktop/podman-desktop#5324 .
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]