Windows-cross linting #21441
Merged
Windows-cross linting #21441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
do-not-merge/work-in-progress
cevich
force-pushed
the
win_lint
branch
2 times, most recently
from
c65477a to
3e4c62c
Compare
openshift-merge-robot
added
the
needs-rebase
cevich
changed the title
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
force-push: Rebased. Assuming CI passes, this should be ready to go. |
edsantiago
suggested changes
Feb 6, 2024
Specifically, Darwin's bash is very old so it doesn't support newer features like `declare -A`. Reduce the complexity of the script so that it can be used for all platforms. Comment heavily regarding the scripts various execution contexts to prevent developers relying on advanced features for any future modifications. Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
As of this commit, there are several pages worth of lint findings for windows. Once they're all addressed, this commit may be reverted to enable continuous checking. Signed-off-by: Chris Evich <[email protected]>
|
LGTM but I won't merge until we get the all-clear from @baude |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit e16d82d
into
containers:main
85 of 89 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #21372
Performing native linting on Windows is quite complex and will require updating the
winmakePS script. As a stop-gap, and until we have an entirely native build -> test chain, run Windows linting prior to the cross-build (on Linux). This isn't a perfect solution, but it does find lots of lint that requires cleaning. To that end, enforcement of cleanliness is temporarily bypassed by in a single revert-friendly commit.Does this PR introduce a user-facing change?