-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include machine-tests in cirrus-cron jobs #21413
Conversation
@mheon PTAL, this should do what you asked. It will take effect the next cirrus-cron run after this is is merged (FYI: @edsantiago @lsm5) @baude If you think it would help, I/we could add a cirrus-cron run for |
LGTM |
Note-to-me: Manually check these tests actually run for the next cron iteration. No e-mail is sent if 'total success' is green - which might be the case here, since machine test status is currently ignored. |
@cevich Can you rebase? |
Force-push: Rebased as requested. |
Cockpit tests failed for commit 4274aceb191928585a1a44d675e6501613ed18a0. @martinpitt, @jelly, @mvollmer please check. |
Might need another rebase? Hyperv fix might not have made it in |
Irrespective of reason/cause, a commit was merged into main that broke podman-machine, and went unnoticed for several days. Improve the situation by including podman-machine testing in the daily cirrus-cron builds. These are monitored by e-mail when `Total Success` reports a failure. Also: Add a comment for Windows & Mac build tasks, documenting the reason they don't execute on RHEL release branches. Signed-off-by: Chris Evich <[email protected]>
NP, there it goes. |
@mheon PTAL this should be ready to go. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rhatdan @Luap99 @baude @ashley-cui PTAL and merge |
/lgtm |
855a7cf
into
containers:main
Irrespective of reason/cause, a commit was merged into main that broke podman-machine, and went unnoticed for several days. Improve the situation by including podman-machine testing in the daily cirrus-cron builds. These are monitored by e-mail when
Total Success
reports a failure.Also: Add a comment for Windows & Mac build tasks, documenting the reason they don't execute on RHEL release branches.
Does this PR introduce a user-facing change?