Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include machine-tests in cirrus-cron jobs #21413

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Jan 29, 2024

Irrespective of reason/cause, a commit was merged into main that broke podman-machine, and went unnoticed for several days. Improve the situation by including podman-machine testing in the daily cirrus-cron builds. These are monitored by e-mail when Total Success reports a failure.

Also: Add a comment for Windows & Mac build tasks, documenting the reason they don't execute on RHEL release branches.

Does this PR introduce a user-facing change?

None

@cevich
Copy link
Member Author

cevich commented Jan 29, 2024

@mheon PTAL, this should do what you asked. It will take effect the next cirrus-cron run after this is is merged (FYI: @edsantiago @lsm5)

@baude If you think it would help, I/we could add a cirrus-cron run for machine-dev-5 similar to this. It would automatically inherit the e-mail monitoring aspect. LMK if interested.

@mheon
Copy link
Member

mheon commented Jan 29, 2024

LGTM
@baude PTAL and merge

@cevich
Copy link
Member Author

cevich commented Jan 29, 2024

Note-to-me: Manually check these tests actually run for the next cron iteration. No e-mail is sent if 'total success' is green - which might be the case here, since machine test status is currently ignored.

@mheon
Copy link
Member

mheon commented Jan 30, 2024

@cevich Can you rebase?

@cevich
Copy link
Member Author

cevich commented Jan 30, 2024

Force-push: Rebased as requested.

Copy link

Cockpit tests failed for commit 4274aceb191928585a1a44d675e6501613ed18a0. @martinpitt, @jelly, @mvollmer please check.

@mheon
Copy link
Member

mheon commented Feb 2, 2024

Might need another rebase? Hyperv fix might not have made it in

Irrespective of reason/cause, a commit was merged into main that broke
podman-machine, and went unnoticed for several days.  Improve the
situation by including podman-machine testing in the daily cirrus-cron
builds.  These are monitored by e-mail when `Total Success` reports a
failure.

Also: Add a comment for Windows & Mac build tasks, documenting the
reason they don't execute on RHEL release branches.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Copy link
Member Author

cevich commented Feb 2, 2024

NP, there it goes.

@cevich
Copy link
Member Author

cevich commented Feb 6, 2024

@mheon PTAL this should be ready to go.

@mheon
Copy link
Member

mheon commented Feb 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@mheon
Copy link
Member

mheon commented Feb 6, 2024

@rhatdan @Luap99 @baude @ashley-cui PTAL and merge

@baude
Copy link
Member

baude commented Feb 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 855a7cf into containers:main Feb 6, 2024
91 of 92 checks passed
@cevich cevich mentioned this pull request Feb 8, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 7, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants