Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bump VMs #21129

Merged
merged 1 commit into from
Jan 3, 2024
Merged

CI: bump VMs #21129

merged 1 commit into from
Jan 3, 2024

Conversation

edsantiago
Copy link
Member

All VMs have pasta 2023-12-04, so, remove a skip.

Signed-off-by: Ed Santiago [email protected]

None

Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@rhatdan
Copy link
Member

rhatdan commented Jan 2, 2024

LGTM
Debians all blew up, restarted, but might be an issue.

@edsantiago
Copy link
Member Author

The debian failure is real; I've just pushed a new VM build to work around it.

All VMs have pasta 2023-12-04, so, remove a skip.

Signed-off-by: Ed Santiago <[email protected]>
@baude
Copy link
Member

baude commented Jan 3, 2024

/hold
/lgtm

@edsantiago giving you the LGTM assuming it finishes, you can drop the hold.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 3, 2024
@edsantiago
Copy link
Member Author

Thanks @baude

I have a memory that there were other tests being skipped, waiting for *vark-1.9. We now have 1.9.0-1 on all Fedoras, but (sigh) I can't remember what those skips were nor can I find any documentation or hints. Does anyone remember what I'm talking about?

@rhatdan
Copy link
Member

rhatdan commented Jan 3, 2024

Nope, perhaps @Luap99 does.

@Luap99
Copy link
Member

Luap99 commented Jan 3, 2024

I am not aware of anything specific, there is a netavark-firewalld-reload.service but that needs a running firewalld which AFAIK is not the case in our CI env and it is already covered by netavark CI tests so I don't think it is strictly required to tests it here.
I definitely do not remember any skips.

@edsantiago
Copy link
Member Author

Thanks.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 490e5ed into containers:main Jan 3, 2024
90 of 93 checks passed
@edsantiago edsantiago deleted the new_vms branch January 3, 2024 12:26
@edsantiago
Copy link
Member Author

WHEW! Found it. Issue was #19809. I removed the skip in #20938, because at that point in time *vark-1.9 was present in all machines where it was needed. All is well.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants