Improve compose tests to report test errors as failures #21046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add traps to report setup, tests, and teardown errors as failures * Pass through return code of podman commands * Fix unset variables * Fix simple_port_map image build when installing flask (PEP 668 - externally managed environment error) * Ignore kill errors in slirp4netns_opts teardown steps Signed-off-by: Gavin Lam <[email protected]>
gavinkflam
changed the title
gavinkflam
changed the title
gavinkflam
commented
Dec 17, 2023
|
Thanks @gavinkflam |
|
Nice work @gavinkflam, thank you. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gavinkflam, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit d161cf3
into
containers:main
91 of 92 checks passed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Luap99 raised a concern about test errors being ignored and not causing failures #21013 (comment). cc @edsantiago
Improvements
Does this PR introduce a user-facing change?