[CI:DOCS] Fix path to example files in contrib/systemd/README.md #21025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Łukasz Stolcman <[email protected]>
Luap99
reviewed
Dec 15, 2023
contrib/systemd/README.md
Outdated
Comment on lines
31
to
37
| ### podman.service | ||
| You can refer to [this example](https://github.com/containers/podman/blob/main/contrib/systemd/user/podman.service) for a rootless podman.service file. | ||
| You can refer to [this example](https://github.com/containers/podman/blob/main/contrib/systemd/system/podman.service.in) for a rootless podman.service file. | ||
|
|
||
| Note: replace `@@PODMAN@@` with path to podman binary, such as `/usr/local/bin/podman` | ||
|
|
||
| ### podman.socket | ||
| You can refer to [this example](https://github.com/containers/podman/blob/main/contrib/systemd/user/podman.socket) for a rootless podman.socket file. | ||
| You can refer to [this example](https://github.com/containers/podman/blob/main/contrib/systemd/system/podman.socket) for a rootless podman.socket file. |
There was a problem hiding this comment.
Given they are duplicated from the above I feel like we should drop this entirely
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, lstolcman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM with Pauls comment addressed. |
Signed-off-by: Łukasz Stolcman <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes links to example files. Currently, only one link works, and the rest leads to 404.
Does this PR introduce a user-facing change?