-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user-mode net init flag on first time install #20929
Fix user-mode net init flag on first time install #20929
Conversation
Previously the WSL user-mode networking distribution was only installed as part of a change, when it should have been also applied installs. This mean that the init flag usage only worked after a previous set command. [NO NEW TESTS NEEDED] Signed-off-by: Jason T. Greene <[email protected]>
LGTM |
various test failures are being worked on and unrelated |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbraad, n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we really need working machine CI tests so we can have regressions test for things like this.
/cherry-pick v4.8 |
@Luap99: once the present PR merges, I will cherry-pick it on top of v4.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
you volunteering @Luap99 ? |
/lgtm |
09d7260
into
containers:main
@Luap99: new pull request created: #20941 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #20921
Previously the WSL user-mode networking distribution was only installed as part of a change, when it should have been also applied installs. This mean that the init flag usage only worked after a previous set command.