Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user-mode net init flag on first time install #20929

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

n1hility
Copy link
Member

@n1hility n1hility commented Dec 6, 2023

Fixes #20921

Previously the WSL user-mode networking distribution was only installed as part of a change, when it should have been also applied installs. This mean that the init flag usage only worked after a previous set command.

Fixed a bug on Windows (WSL) with the first-time install of user-mode networking when using the init command, as opposed to set (#20921)

Previously the WSL user-mode networking distribution was only installed as part
of a change, when it should have been also applied installs. This mean that the
init flag usage only worked after a previous set command.

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <[email protected]>
@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2023
@rhatdan
Copy link
Member

rhatdan commented Dec 6, 2023

LGTM

@n1hility
Copy link
Member Author

n1hility commented Dec 6, 2023

various test failures are being worked on and unrelated

Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbraad, n1hility

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Dec 7, 2023

LGTM.
@baude PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we really need working machine CI tests so we can have regressions test for things like this.

@Luap99
Copy link
Member

Luap99 commented Dec 7, 2023

/cherry-pick v4.8

@openshift-cherrypick-robot
Copy link
Collaborator

@Luap99: once the present PR merges, I will cherry-pick it on top of v4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick v4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@baude
Copy link
Member

baude commented Dec 7, 2023

LGTM, but we really need working machine CI tests so we can have regressions test for things like this.

you volunteering @Luap99 ?

@baude
Copy link
Member

baude commented Dec 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 09d7260 into containers:main Dec 7, 2023
88 of 92 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@Luap99: new pull request created: #20941

In response to this:

/cherry-pick v4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Mar 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman 4.8.1 machine init fails with Error: existing machine configuration is corrupt, no image is defined
7 participants