Add API forwarding support for HyperV

[ashley-cui]

Provides Docker API client access, allowing compose to work by default for HyperV. Basically the HyperV equiv of the work done here by #12916.

[NO NEW TESTS NEEDED]

Closes #20761

Fixed a bug where Podman machine on HyperV did not allow API forwarding

[ashley-cui]

@n1hility @jeffmaury PTAL. Tested and it seems to work for me.

[ashley-cui]

@containers/podman-maintainers @mheon @baude PTAL, would like to get this into v4.8.1 if possible

[packit-as-a-service]

Cockpit tests failed for commit 13ade675756ecc201cafac720cf61f3a93fdcbad. @martinpitt, @jelly, @mvollmer please check.

[martinpitt]

Yup, that's a regression in criu in podman-next. We see it in our nightly runs against podman-next as well, it fails on the same "criu restore" check. I'll investigate/report on Monday.

[rhatdan]

LGTM

[giuseppe]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ashley-cui,giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jeffmaury]

LGTM but I add to add ssh-keygen to get the machine created

[n1hility]

Sorry this one fell through the cracks for me and the very late review. This LGTM

This is not a blocker at all, but just mentioning to factor in / consider for the future. Since the hyperv code uses gvproxy for ssh routing / port forwarding, if we wanted to save a process and drop usage of win-sshproxy the ssh options on gvproxy could be used for this purpose instead (like what we do on mac). It's still a trade-off to some extent since it would mean differences between the hyperv and wsl code.

[rhatdan]

/lgtm
/hold

[jeffmaury]

I have 2 remarks:

• when the machine is stopped the win-sshproxy processed is not stopped
• If I run podman compose against https://github.com/docker/awesome-compose/tree/master/flask-redis, I have the following error (which I don't have with a WSL machine):

C:\Users\Jeff\work\src\github.com\docker\awesome-compose\flask-redis>podman compose up -d
>>>> Executing external compose provider "C:\\Users\\Jeff\\AppData\\Local\\Microsoft\\WindowsApps\\docker-compose.exe". Please refer to the documentation for details. <<<<

[+] Running 2/0
 ✔ Network flask-redis_default    Created                                                                          0.0s
 ✔ Container flask-redis-redis-1  Created                                                                          0.1s
 - Container flask-redis-web-1    Creating                                                                         0.0s
Error response from daemon: fill out specgen: C:\Users\Jeff\work\src\github.com\docker\awesome-compose\flask-redis:/code:rw: incorrect volume format, should be [host-dir:]ctr-dir[:option]
Error: executing C:\Users\Jeff\AppData\Local\Microsoft\WindowsApps\docker-compose.exe up -d: exit status 1

[rhatdan]

@ashley-cui needs a rebase

[ashley-cui]

@jeffmaury

• when the machine is stopped the win-sshproxy processed is not stopped

Updated, thanks!

• If I run podman compose against https://github.com/docker/awesome-compose/tree/master/flask-redis, I have the following error (which I don't have with a WSL machine):

This is another followup issue, where the parsing of mounts on HyperV requires absolute paths. Will address this later.

[ashley-cui]

Should be good to go, I think the mac failure is unrelated.

[jakecorrenti]

/lgtm

[jakecorrenti]

/unhold

[ashley-cui]

/cherry-pick v4.8

[openshift-cherrypick-robot]

@ashley-cui: #20878 failed to apply on top of branch "v4.8":

Applying: Add API forwarding support for HyperV
Using index info to reconstruct a base tree...
M	cmd/podman/compose.go
M	pkg/machine/hyperv/machine.go
M	pkg/machine/machine_windows.go
M	pkg/machine/wsl/machine.go
M	pkg/machine/wsl/usermodenet.go
M	pkg/machine/wsl/util_windows.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/machine/wsl/util_windows.go
Auto-merging pkg/machine/wsl/usermodenet.go
Auto-merging pkg/machine/wsl/machine.go
Auto-merging pkg/machine/machine_windows.go
Auto-merging pkg/machine/hyperv/machine.go
Auto-merging cmd/podman/compose.go
CONFLICT (content): Merge conflict in cmd/podman/compose.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add API forwarding support for HyperV
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick v4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.