Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Remove unnencessary pregenerated doc #20763

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

arixmkii
Copy link
Contributor

@arixmkii arixmkii commented Nov 23, 2023

It is generated from podman-farm-build.1.md.in. Most notably it fails builds on Windows with msys2, because Python os.rename can't silently replace files on that platform and podman-farm-build.1.md is already if the filesystem.

I manually verified that podman-farm-build.1.md is created during build.

Does this PR introduce a user-facing change?

None

Signed-off-by: Arthur Sengileyev <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umohnani8 PTAL

Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arixmkii, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@rhatdan
Copy link
Member

rhatdan commented Nov 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 375065c into containers:main Nov 25, 2023
42 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
@arixmkii arixmkii deleted the fix-farm-docs branch March 1, 2024 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants