Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Machine test timeout env var #20696

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ashley-cui
Copy link
Member

@ashley-cui ashley-cui commented Nov 15, 2023

Introduce MACHINE_TEST_TIMEOUT, which sets the timeout for machine tests, in seconds.

Does this PR introduce a user-facing change?

None

Introduce MACHINE_TEST_TIMEOUT, which sets the timeout for machine tests, in seconds.

Signed-off-by: Ashley Cui <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Nov 15, 2023
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Nov 15, 2023
@ashley-cui
Copy link
Member Author

@baude PTAL

@cevich
Copy link
Member

cevich commented Nov 15, 2023

LGTM - this fixes the problem and the added flexibility will come in handy as the CI grows/evolves. Thanks!

@baude
Copy link
Member

baude commented Nov 15, 2023

nice catch @ashley-cui

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit ec2e533 into containers:main Nov 15, 2023
41 checks passed
@ashley-cui ashley-cui deleted the ci branch January 8, 2024 20:49
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants