Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] vendor: force zstd:chunked compression #20633

Closed
wants to merge 4 commits into from
Closed

[TEST] vendor: force zstd:chunked compression #20633

wants to merge 4 commits into from

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Nov 8, 2023

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 8, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@giuseppe giuseppe mentioned this pull request Nov 8, 2023
Open
@giuseppe giuseppe force-pushed the force-zstd-chunked branch 2 times, most recently from f1eeb4e to 7a352c3 Compare November 8, 2023 19:56
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@rhatdan
Copy link
Member

rhatdan commented Nov 8, 2023

Looking good.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2023
@giuseppe giuseppe force-pushed the force-zstd-chunked branch 2 times, most recently from c053abc to 40be84a Compare November 9, 2023 12:48
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2023
@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit b51d92efd37ef2932b083a49d3c32dbaacd0195f. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 8ee517d0c2fc814c9e04ce0f1d00033bead8befa. @martinpitt, @jelly, @mvollmer please check.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2023
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@giuseppe
Copy link
Member Author

Some tests need to be adjusted since they assume gzip.

Beside that, we need:

  • copy: do not fail if digest mismatches image#1980
  • find a way to deal with zstd:chunked compression in the blob cache. In the test PR I've used giuseppe/image@cb9adff to store zstd:chunked blobs as zstd, I'll more into this if there is a way to differentiate between zstd and zstd:chunked. But we could start from a simple fix as the previous one to get started.

I can polish this PR and drop the vendor patch, so while we sort out the missing pieces in c/storage, we already have a working base to start from. What do you think?

@giuseppe giuseppe mentioned this pull request Nov 10, 2023
Merged
@flouthoc flouthoc mentioned this pull request Nov 13, 2023
Closed
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2023
@giuseppe giuseppe force-pushed the force-zstd-chunked branch 2 times, most recently from 2f1b28c to e0ca217 Compare November 14, 2023 12:47
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2023
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtrmac mtrmac mentioned this pull request Feb 8, 2024
Draft
@giuseppe giuseppe closed this Feb 8, 2024
@mtrmac mtrmac mentioned this pull request Mar 1, 2024
Draft
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 9, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giuseppe @rhatdan @openshift-merge-robot