Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Bump pre-commit version. #20546

Closed
wants to merge 1 commit into from

Conversation

cevich
Copy link
Member

@cevich cevich commented Oct 31, 2023

Some odd python errors are popping up during the validate CI task:

Traceback (most recent call last):
  File "/root/.cache/pre-commit/repo9hh_1zk3/py_env-python3/bin/check-yaml", line 5, in <module>
    from pre_commit_hooks.check_yaml import main
  File "/root/.cache/pre-commit/repo9hh_1zk3/py_env-python3/lib/python3.11/site-packages/pre_commit_hooks/check_yaml.py", line 10, in <module>
    yaml = ruamel.yaml.YAML(typ='safe')
           ^^^^^^^^^^^^^^^^

Attempt to fix them with an update.

Does this PR introduce a user-facing change?

None

Some odd python errors are popping up during the validate CI task:

```
Traceback (most recent call last):
  File "/root/.cache/pre-commit/repo9hh_1zk3/py_env-python3/bin/check-yaml", line 5, in <module>
    from pre_commit_hooks.check_yaml import main
  File "/root/.cache/pre-commit/repo9hh_1zk3/py_env-python3/lib/python3.11/site-packages/pre_commit_hooks/check_yaml.py", line 10, in <module>
    yaml = ruamel.yaml.YAML(typ='safe')
           ^^^^^^^^^^^^^^^^
```

Attempt to fix them with an update.

Signed-off-by: Chris Evich <[email protected]>
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cevich
Once this PR has been reviewed and has the lgtm label, please assign mheon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich
Copy link
Member Author

cevich commented Oct 31, 2023

Ugh, I really don't know what's going on with the ARM64 precommit python stuffs 😞 Pertinent facts:

  1. It doesn't fail on main
  2. It doesn't fail on x86_64
  3. All arch's are using the distro-supplied python and python-devel packages.
  4. This branch is using older CI VM images

I don't really have time to spend debugging this right now. Suggest maybe for this branch we just disable only the pre-commit check when running on ARM. IMHO, multi-arch pre-commit isn't really adding much/any value.

@cevich cevich closed this Oct 31, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant