CI: systest: safer random_rfc1918_subnet #20494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
Luap99
reviewed
Oct 26, 2023
Our aarch64 CI system uses 172.31.0.0/20. Because I was (and am) lazy, my random_rfc1918_subnet() helper was only checking /24. This causes flakes. Solution is to actually do it right: binary arithmetic, prefix matching. This is effectively impossible in bash, so, use a hairy perl helper and add copious tests. Fixes: containers#18693 Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
systest_subnet_check
branch
from
c8d0523 to
9e3363c
Compare
Luap99
approved these changes
Oct 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our aarch64 CI system uses 172.31.0.0/20. Because I was (and am)
lazy, my random_rfc1918_subnet() helper was only checking /24.
This causes flakes.
Solution is to actually do it right: binary arithmetic, prefix
matching. This is effectively impossible in bash, so, use a
hairy perl oneliner and add copious tests.
Note: I considered
ipcalc,ipcalc-ng,sipcalc, various python packages. Given our system-test constraints where we need to run on fedora, debian, and RHEL, I believe this is the safest approach in terms of portability. There may be cleaner options I did not consider, so please speak up if you have better suggestions.Fixes: #18693
Signed-off-by: Ed Santiago [email protected]