Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emergency workaround for CI breakage #20404

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Emergency workaround for CI breakage #20404

merged 1 commit into from
Oct 18, 2023

Conversation

edsantiago
Copy link
Member

@edsantiago edsantiago commented Oct 18, 2023 •
edited
Loading

Skip new exec-leak test from #20394, it breaks under podman-remote. (How did it ever pass CI??)

Signed-off-by: Ed Santiago [email protected]

None

@edsantiago
Emergency workaround for CI breakage
44ed415 
Skip new exec-leak test

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2023
giuseppe
giuseppe approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [edsantiago,giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@edsantiago
Copy link
Member Author

Thanks, but, can't lgtm until CI is complete.

@edsantiago edsantiago mentioned this pull request Oct 18, 2023
Merged
@giuseppe
Copy link
Member

working on a fix for the remote case: #20405

@edsantiago
Copy link
Member Author

Thank you!

@edsantiago
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@openshift-ci openshift-ci bot merged commit d4086f5 into containers:main Oct 18, 2023
98 checks passed
@edsantiago edsantiago deleted the emergency_ci_fix branch October 18, 2023 19:25
@edsantiago edsantiago mentioned this pull request Oct 18, 2023
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edsantiago @giuseppe