libpod: restart+userns cleanup netns correctly #20384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a userns and netns is used we need to let the runtime create the netns otherwise the netns is not owned by the right userns and thus the capabilities would not be correct. The current restart logic tries to reuse the netns which is fine if no userns is used but when one is used we setup a new netns (which is correct) but forgot to cleanup the old netns. This resulted in leaked network namespaces and because no teardown was ever called leaked ipam assignments, thus a quickly restarting container will run out of ip space very fast. Fixes containers#18615 Signed-off-by: Paul Holzinger <[email protected]>
openshift-ci
bot
added
release-note
approved
|
Do we need to do this in the typical restart codepath, node just restart policy handling? |
|
The typical restart does not preserve the netns, see 6d487c7 |
|
LGTM |
vrothberg
approved these changes
Oct 18, 2023
| fi | ||
|
|
||
| local net1=a-$(random_string 10) | ||
| # use /29 subnet to limt available ip space, a 29 gives 5 useable addresses (6 - 1 for the gw) |
There was a problem hiding this comment.
Nits
Suggested change
| # use /29 subnet to limt available ip space, a 29 gives 5 useable addresses (6 - 1 for the gw) | |
| # use /29 subnet to limit available ip space, a 29 gives 5 usable addresses (6 - 1 for the gw) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a userns and netns is used we need to let the runtime create the netns otherwise the netns is not owned by the right userns and thus the capabilities would not be correct.
The current restart logic tries to reuse the netns which is fine if no userns is used but when one is used we setup a new netns (which is correct) but forgot to cleanup the old netns. This resulted in leaked network namespaces and because no teardown was ever called leaked ipam assignments, thus a quickly restarting container will run out of ip space very fast.
Fixes #18615
Does this PR introduce a user-facing change?