Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildah: bump to v1.32.1-0.20231012130144-244170240d85 and test builds with relative TMPDIR #20367

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

flouthoc
Copy link
Collaborator

Does this PR introduce a user-facing change?

buildah: bump to `v1.32.1-0.20231012130144-244170240d85` and test builds with relative `TMPDIR`

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 16, 2023
Signed-off-by: Aditya R <[email protected]>
Test edge-case described here: containers/buildah#5084
Test case in: RHEL-2598

Signed-off-by: Aditya R <[email protected]>
@flouthoc flouthoc force-pushed the bump-and-test-buildah branch from 64b60fa to 331e47a Compare October 16, 2023 08:32
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Oct 16, 2023
@flouthoc flouthoc force-pushed the bump-and-test-buildah branch from 8d0fb86 to 5db3b75 Compare October 16, 2023 10:04
@flouthoc flouthoc requested a review from Luap99 October 16, 2023 10:04
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,flouthoc,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flouthoc
Copy link
Collaborator Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@openshift-ci openshift-ci bot merged commit dabf6c8 into containers:main Oct 16, 2023
98 of 99 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants