Show client info even if remote connection fails

[baude]

When people report issues, we often ask for the result of podman info. However, if the problem is the remote connection, it will error out with no information at all. This PR at least will report client information before disclosing the connection error. For example on Windows:

.\bin\windows\podman.exe info
client:
OS: windows/amd64
provider: hyperv
version: 4.8.0-dev
host: null
...

Satisfies: RUN-1720

Does this PR introduce a user-facing change?

podman info now reports client information even if the remote connection is unreachable

[edsantiago]

Nice! Very easy to add a system test, should you want to & should you need to repush:

run_podman 125 --url unix://localhost/no/such/path info
assert "$output" =~ "host: null"
assert "$output" =~ "Error: unable to connect to Podman socket"

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[lsm5]

Ephemeral COPR build failed. @containers/packit-build please check.

ignore eln

[rhatdan]

LGTM, other then cross compiler issues.

[Luap99]

This is a API change and nothing is ever set via API so this makes little sense to expose this over the wire.

I recommend to add a new type on the client side only, something like this in cmd/podman/system/info.go:

type Info struct {
	*define.Info
	Client *ClientInfo `json:"client"`
}

type ClientInfo struct {
	OSArch   string `json:"OS"`
	Provider string `json:"provider"`
	Version  string `json:"version"`
}

[baude]

ok, fair enough ... i kind of figured that was coming.

[baude]

Nice! Very easy to add a system test, should you want to & should you need to repush:

run_podman 125 --url unix://localhost/no/such/path info
assert "$output" =~ "host: null"
assert "$output" =~ "Error: unable to connect to Podman socket"

what file should i add that to?

[edsantiago]

001-basic or 005-info. The former already has a few tests that use --url (with the requisite skip_if_remote), the latter is possibly more suited toward a test of podman info. In either case I think it could be piggybacked onto an existing test.

[baude]

meh, i pushed before i saw your comment; lets see how things go

[edsantiago]

Suggestion:

--- a/test/system/272-system-connection.bats
+++ b/test/system/272-system-connection.bats
@@ -104,3 +104,3 @@ $c2[ ]\+tcp://localhost:54321[ ]\+true" \
     is "$output" \
-       "Cannot connect to Podman. Please verify.*dial tcp.*connection refused" \
+       "OS: .*provider:.*Cannot connect to Podman. Please verify.*dial tcp.*connection refused" \
        "podman info, without active service"

[Luap99]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm
/hold

[edsantiago]

/hold cancel

Thanks, @baude