Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't ignore containerfiles outside of build context #20288

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix: don't ignore containerfiles outside of build context #20288

merged 2 commits into from
Oct 9, 2023

Conversation

albnnc
Copy link
Contributor

@albnnc albnnc commented Oct 6, 2023

Closes #20259

Does this PR introduce a user-facing change?

None

@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@albnnc albnnc force-pushed the fix/do-not-ignore-external-containerfiles branch from 6d71aef to 5f4dc9f Compare October 6, 2023 10:53
@lsm5
Copy link
Member

lsm5 commented Oct 6, 2023

@albnnc thanks for the PR. Could you please sign off your commit. See: https://github.com/containers/podman/pull/20288/checks?check_run_id=17462199768

Also, you might need to add [NO NEW TESTS NEEDED] to your commit message if there are no new tests required here. See: https://github.com/containers/podman/pull/20288/checks?check_run_id=17462202036

The rpm-build:fedora-eln test failures can be ignored for now.

@rhatdan
Copy link
Member

rhatdan commented Oct 6, 2023

I would rather add a system tests to this for a Containerfile outside of the build root.

@albnnc
Don't ignore containerfiles outside of build context
3fdb6ee 
[NO NEW TESTS NEEDED]

Signed-off-by: Aleksei Kosyrev <[email protected]>
@albnnc albnnc force-pushed the fix/do-not-ignore-external-containerfiles branch from 5f4dc9f to 3fdb6ee Compare October 6, 2023 13:00
@albnnc
Copy link
Contributor Author

albnnc commented Oct 6, 2023 •
edited
Loading

I would rather add a system tests to this for a Containerfile outside of the build root.

I've added one which passes now and don't pass on older version of podman.

Edit:

Cleaned up unwanted mess in containerfile now.

@albnnc
Add system test
732cec7 
Signed-off-by: Aleksei Kosyrev <[email protected]>
@albnnc albnnc force-pushed the fix/do-not-ignore-external-containerfiles branch from f35390a to 732cec7 Compare October 7, 2023 07:56
@rhatdan
Copy link
Member

rhatdan commented Oct 7, 2023

LGTM

giuseppe
giuseppe approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albnnc, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2023
@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@openshift-ci openshift-ci bot merged commit b2c5418 into containers:main Oct 9, 2023
94 of 97 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wildcard in .containerignore combined with containerfile outside of build context leads to an error
4 participants
@albnnc @lsm5 @rhatdan @giuseppe