Use logical AND on chained label! filters instead of logical OR #20197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the filter matching for chained negated labels (label!) on containers, networks, and volumes. When pruning with chained label! filters, the filters will be ANDed instead of ORed. Fixes: 17413 Signed-off-by: Jake Correnti <[email protected]>
openshift-ci
bot
added
release-note-action-required
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jakecorrenti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Needs containers/common#1677 to merge first |
|
Cockpit tests failed for commit 515d711. @martinpitt, @jelly, @mvollmer please check. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the filter matching for chained negated labels (label!) on containers, networks, and volumes. When pruning with chained label! filters, the filters will be ANDed instead of ORed.
Fixes: #17413
Does this PR introduce a user-facing change?