[CI:DOCS] Add win-sshproxy target to winmake #20157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ashley-cui
force-pushed
the
makesshproxy
branch
from
784d96f to
7268437
Compare
ashley-cui
changed the title
ashley-cui
changed the title
openshift-ci
bot
added
release-note-none
and removed
do-not-merge/release-note-label-needed
ashley-cui
force-pushed
the
makesshproxy
branch
from
7268437 to
f6c41c0
Compare
cevich
reviewed
Sep 26, 2023
|
LGTM (aside from @cevich 's followup suggestion on maybe we should leave the sha holdover for the current version tag) |
ashley-cui
force-pushed
the
makesshproxy
branch
from
f6c41c0 to
1e952df
Compare
Winmake file now builds win-sshproxy and gvproxy Signed-off-by: Ashley Cui <[email protected]>
ashley-cui
force-pushed
the
makesshproxy
branch
from
1e952df to
149d3f7
Compare
|
LGTM |
|
/lgtm |
|
Nice work Ashley. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winmake file now builds win-sshproxy and gvproxy
Does this PR introduce a user-facing change?