Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apparmor_linux.go to parse apparmor version 4.0.0~alpha2 without error #19962

Closed
wants to merge 2 commits into from

Conversation

jelber2
Copy link

@jelber2 jelber2 commented Sep 13, 2023

Does this PR introduce a user-facing change?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jelber2
Once this PR has been reviewed and has the lgtm label, please assign vrothberg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@martinpitt
Copy link
Contributor

@lsm5 , all: The cockpit-revdeps tests started to fail because of some issue in the testing farm, it's not installing the correct cockpit-podman RPM (it needs to come from the daily COPR, not the testing-farm-tag-repository). @jelly is investigating. Until then, please ignore, or disable them in your packit.yaml if it annoys you. Sorry!

@Luap99
Copy link
Member

Luap99 commented Sep 13, 2023

@jelber2 You cannot manually change files under vendor/. These changes must go into the upstream repo first then we can update them here.
It would also help if you would explain why you are changing this?

@jelber2
Copy link
Author

jelber2 commented Sep 13, 2023

@Luap99 I had to make the changes to use podman and the version of apparmor that I have on my system, 4.0.0~alpha2. Without the changes to split at the ~, podman fails with a parsing error.

@Luap99
Copy link
Member

Luap99 commented Sep 13, 2023

That would be helpful to add to the commit message, but in any case you can edit these files here directly. You must first propose the changes upstream (https://github.com/containers/common/) before we can update it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants