Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency containers/automation_images to v20230807 #19541

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 7, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
containers/automation_images major 20230726t191046z-f38f37d13 -> 20230807t144831z-f38f37d13

Release Notes

containers/automation_images (containers/automation_images)

v20230807t144831z-f38f37d13

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file release-note-none labels Aug 7, 2023
@renovate renovate bot requested a review from cevich August 7, 2023 17:48
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT MERGE: There's a FIXME that requires fixing.

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 1a35a87 to e4c1ea5 Compare August 7, 2023 18:37
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still DO NOT MERGE: I want to see if the "lookup cdn03.quay.io" flake still reproduces.

@edsantiago
Copy link
Member

If you test this in podman, it's imperative to do with without flakeretries. Otherwise e2e failures will be invisible.

FWIW Miro Vadkerti was seeing the cdn03 bug a week or two ago in his testing farm. There is very high confidence that the bug persists.

@cevich
Copy link
Member

cevich commented Aug 7, 2023

Otherwise e2e failures will be invisible.

Oh okay thanks. I'll just grep the ginkgo log files then (assuming we still collect them).

There is very high confidence that the bug persists.

Noted.

@cevich
Copy link
Member

cevich commented Aug 7, 2023

Ugg, speak of the devil. This flake reproduced on the 4.4.1-rhel branch cirrus-cron run the other night. So it's definitely still alive and kicking 😢

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from e4c1ea5 to 407cfe5 Compare August 7, 2023 19:04
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass.

@renovate
Copy link
Contributor Author

renovate bot commented Aug 7, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@cevich
Copy link
Member

cevich commented Aug 8, 2023

@edsantiago any chance you've seen this debian Error: OCI runtime error: runc: exec failed: unable to start container process: exec: "/etc": is a directory? I didn't see it on the flake list.

It's dying on the entire debian matrix 😢

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Chris Evich <[email protected]>
@edsantiago
Copy link
Member

My first guess is that runc changed, and is now emitting a different exit status.

@cevich
Copy link
Member

cevich commented Aug 8, 2023

Force-push: Rebased. Small fix for Ed. Add one test skip, removed another.

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from 6adf2e9 to b261cd8 Compare August 8, 2023 15:58
cevich added 4 commits August 8, 2023 14:34
An unhelpful comment doesn't give any clues why this test was originally
skipped on Ubuntu.  In any case, now that CI uses Debian SID, re-enable
the test hoping that it now functions.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Copy link
Member

cevich commented Aug 8, 2023

garrr...I fat-fingered my fix to Ed's date 😱

@cevich cevich force-pushed the renovate/major-ci-vm-image branch from b261cd8 to 7ef0351 Compare August 8, 2023 18:35
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ready for final review assuming tests pass.

@cevich
Copy link
Member

cevich commented Aug 8, 2023

Thanks to the kind-soul whom is re-running CI jobs 👍

@rhatdan
Copy link
Member

rhatdan commented Aug 8, 2023

/approved

@edsantiago
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@edsantiago edsantiago added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: cevich, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d4f967c into main Aug 8, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants