-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default ulimit test for gen kube #18733
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current way of setting default ulimits is just broken, see #18714 and #18696.
Instead of keeping this it is IMO better to move setting the default limits down in libpod and set it on each start. Then we do not alter ctr.config.Spec which means your kube generate code can just stay as it without changes.
@umohnani8 I think if we merge #18721 then you do not need any code changes at all, you could just add your test to prevent future regressions. |
Add a test for generate kube to verify that the ulimit annotation is not set for the default case when the user doesn't set any ulimits. Signed-off-by: Urvashi Mohnani <[email protected]>
@containers/podman-maintainers PTAL |
im taking comments from @Luap99 to indicate his LGTM /lgtm |
Add a test for generate kube to verify that the ulimit
annotation is not set for the default case when the user
doesn't set any ulimits.
Fixes #18555
Implementation was done in #18721 and this PR adds a regression test.
Does this PR introduce a user-facing change?