stats: get mem limit from the cgroup #18630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
giuseppe
force-pushed
the
fix-mem-limit-stats
branch
3 times, most recently
from
90f9c1f to
35b533d
Compare
Luap99
reviewed
May 19, 2023
giuseppe
force-pushed
the
fix-mem-limit-stats
branch
from
35b533d to
b822c40
Compare
yes that is a better idea. Added |
|
LGTM |
openshift-ci
bot
added
the
do-not-merge/hold
giuseppe
force-pushed
the
fix-mem-limit-stats
branch
from
b822c40 to
89087bc
Compare
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
fix-mem-limit-stats
branch
from
89087bc to
7c53a46
Compare
|
/lgtm |
openshift-ci
bot
added
lgtm
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b25b330 introduced this behaviour.
It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup.
containers/crun#1217 is required for crun.
[NO NEW TESTS NEEDED] needs a new crun release
Closes: #18621
Does this PR introduce a user-facing change?