compat: accept tag in /images/create?fromSrc #18598
Conversation
openshift-ci
bot
added
release-note
approved
github-actions
bot
added
the
kind/api-change
test/apiv2/test-apiv2
Outdated
| # TODO: this is just some hack to avoid adding `-d {}` to curl for endpoints where we really need an empty body | ||
| -) curl_args+=(--disable); | ||
| shift;; |
There was a problem hiding this comment.
@edsantiago PTAL, I guess you have a better idea how to address this. Basically I have to prevent the jsonify logic below. I need an empty body for the test to work.
There was a problem hiding this comment.
Well.... I give up. I tried some different ideas on changing how/when -d {} gets set, but everything failed in different ways. If this approach works out for you, I'm OK with it.
There was a problem hiding this comment.
OK, repushed with a bit more comments.
|
code, etc, LGTM, test failures otherwise I would merge. |
Accept a tag in the compat api endpoint. For the fromImage param we already parse it but for fromSrc we did not. Fixes containers#18597 Signed-off-by: Paul Holzinger <[email protected]>
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
LGTM and happy green test buttons |
github-actions
bot
added
the
locked - please file new issue/PR
Accept a tag in the compat api endpoint. For the fromImage param we already parse it but for fromSrc we did not.
Fixes #18597
Does this PR introduce a user-facing change?