[CI:DOCS] Fix documentation of --network-cmd-path CLI option
#18569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--network-cmd-path` CLI option only affects rootless networks using `slirp4netns(1)`, not `pasta(1)`. Following containers#18568 Podman should rather use the more generic `r.config.FindHelperBinary()` method (and therefore honour the `helper_binaries_dir` config) to find the path to the `slirp4netns` binary and deprecate the misleading `--network-cmd-path` CLI option. However, since this wasn't implemented yet we can't deprecate `--network-cmd-path` as of now. Adding a note anyway. Fixes containers#18560 Signed-off-by: Daniel Rudolf <[email protected]>
openshift-ci
bot
added
the
approved
sbrivio-rh
approved these changes
May 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, PhrozenByte, sbrivio-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--network-cmd-pathCLI option only affects rootless networks usingslirp4netns(1), notpasta(1). Following #18568 Podman should rather use the more genericr.config.FindHelperBinary()method (and therefore honour thehelper_binaries_dirconfig) to find the path to theslirp4netnsbinary and deprecate the misleading--network-cmd-pathCLI option. However, since this wasn't implemented yet we can't deprecate--network-cmd-pathas of now. Adding a note anyway.Fixes #18560
Does this PR introduce a user-facing change?
Cc: @Luap99