Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync machine docker.sock according to rootful flag #18554

Merged
merged 1 commit into from
May 15, 2023

Conversation

n1hility
Copy link
Member

Resolves #18480 on Mac, Linux, and Windows

Podman machine now updates /run/docker.sock within the guest to be consistent with its rootless/rootful setting

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n1hility

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2023
pkg/machine/config.go Outdated Show resolved Hide resolved
@n1hility n1hility force-pushed the sync-docker-sock branch from c713611 to 5a176f0 Compare May 15, 2023 04:56
@n1hility
Copy link
Member Author

Also updated PR for applehv and hyperv providers. Will check test status in the morning

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented May 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4c399fc into containers:main May 15, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when running in podman rootless the created /var/run/docker.sock links to non existent file in podman machine
4 participants