manifest, push: use source as destination if not specified
#18395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
flouthoc
added a commit
to flouthoc/buildah
that referenced
this pull request
May 1, 2023
`manifest push <source>` must work as-is if source is actually a valid path and no destination is provided, buildah must internally choose source as its destination just like `podman push`. PR is similar to: containers/podman#18395 Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
manifest-push-merge-dest
branch
from
1558a1d to
711ca62
Compare
`manifest push <source>` must work as-is if `source` is actually a valid path and no destination is provided, `podman` must internally choose `source` as its `destination` just like `podman push` See: https://github.com/containers/podman/blob/main/cmd/podman/images/push.go#L161 Closes: containers#18360 Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
manifest-push-merge-dest
branch
from
711ca62 to
bab4217
Compare
rhatdan
reviewed
May 1, 2023
| @@ -114,7 +114,7 @@ func push(cmd *cobra.Command, args []string) error { | |||
| return err | |||
| } | |||
| listImageSpec := args[0] | |||
| destSpec := args[1] | |||
| destSpec := args[len(args)-1] | |||
|
@containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
reviewed
May 2, 2023
| Expect(session).To(ExitWithError()) | ||
| // Push should actually fail since its not valid registry | ||
| Expect(session.ErrorToString()).To(ContainSubstring("requested access to the resource is denied")) | ||
| Expect(session.OutputToString()).To(Not(ContainSubstring("accepts 2 arg(s), received 1"))) |
There was a problem hiding this comment.
this NOT check is pointless, you would need to match ErrorToString to string in order to actually check what you are trying to do. General speaking given that you already check for the error message above you could just drop this check.
flouthoc
added a commit
to flouthoc/buildah
that referenced
this pull request
May 4, 2023
`manifest push <source>` must work as-is if source is actually a valid path and no destination is provided, buildah must internally choose source as its destination just like `podman push`. PR is similar to: containers/podman#18395 Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/buildah
that referenced
this pull request
May 4, 2023
`manifest push <source>` must work as-is if source is actually a valid path and no destination is provided, buildah must internally choose source as its destination just like `podman push`. PR is similar to: containers/podman#18395 Signed-off-by: Aditya R <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manifest push <source>must work as-is ifsourceis actually a valid path and no destination is provided,podmanmust internally choosesourceas itsdestinationjust likepodman pushSee: https://github.com/containers/podman/blob/main/cmd/podman/images/push.go#L161
Closes: #18360
Does this PR introduce a user-facing change?