-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Resolve symlink path for qemu directory if possible" #18322
Conversation
Thanks, you need to add your sign off to the commit. And I assume you also need to add |
Huh, I reviewed the PR guidelines and remembered a signature was required. It prompted for my GPG signature (which I entered), so I thought I got that part right. Will try again.
Done |
This reverts commit 6b64589 (Resolve symlink path for qemu directory if possible). Fully resolving the symlink to qemu solves some issues for aarch64-darwin nix with regards to finding `edk2-aarch64-code.fd`, but unfortunately the fully resolved path includes the version number, making it so that even patch updates break the path to homebrew-installed qemu files. Fixes containers#18111 [NO NEW TESTS NEEDED] Signed-off-by: Nathan Henrie <[email protected]>
Ah, got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@baude @ashley-cui PTAL
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, n8henrie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
Is this deployed to 1.0.1? I still get the same error on M1 . |
I don't think so, lets get this into 4.5.1 /cherry-pick v4.5 |
@Luap99: new pull request created: #18677 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit 6b64589 (Resolve
symlink path for qemu directory if possible).
Fully resolving the symlink to qemu solves some issues for
aarch64-darwin nix with regards to finding
edk2-aarch64-code.fd
, butunfortunately the fully resolved path includes the version number,
making it so that even patch updates break the path to
homebrew-installed qemu files.
Fixes #18111
Does this PR introduce a user-facing change?