Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.5.0 release #18200

Merged
merged 3 commits into from
Apr 14, 2023
Merged

v4.5.0 release #18200

merged 3 commits into from
Apr 14, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Apr 14, 2023

Does this PR introduce a user-facing change?

None

Depends on #18199 . Let's merge that first in case release notes need any updates.

@mheon @ashley-cui PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@lsm5 lsm5 changed the title v4.5.0 release [DO NOT MERGE] v4.5.0 release Apr 14, 2023
@lsm5 lsm5 force-pushed the v4.5.0-release branch 2 times, most recently from f4a0282 to 655448a Compare April 14, 2023 13:17
@lsm5 lsm5 changed the title [DO NOT MERGE] v4.5.0 release v4.5.0 release Apr 14, 2023
@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

hmm why are the 2 commits unverified? Give me a few mins ...

@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

alright, good to go. PTAL @ashley-cui @mheon

RELEASE_NOTES.md Outdated Show resolved Hide resolved
lsm5 and others added 3 commits April 14, 2023 09:27
Co-authored-by: Ashley Cui <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

@ashley-cui Done PTAL

@ashley-cui
Copy link
Member

LGTM :)

@mheon
Copy link
Member

mheon commented Apr 14, 2023

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
@lsm5
Copy link
Member Author

lsm5 commented Apr 14, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit e6055de into containers:v4.5 Apr 14, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
@lsm5 lsm5 deleted the v4.5.0-release branch October 25, 2024 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants