Support Deployment generation with kube generate

[umohnani8]

The podman kube generate command can now generate a
Deployment kind when the --type flag is set to deployment.
By default, a Pod spec will be generated if --type flag is
not set.
Add --replicas flag to kube generate to allow users to set
the value of replicas in the generated yaml when generating a
Deployment kind.
Add e2e and minikube tests for this feature.

Fixes #17712

Signed-off-by: Urvashi Mohnani [email protected]

Does this PR introduce a user-facing change?

Add support to generate k8s Deployment kind with podman kube generate.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[umohnani8]

Deployment generation examples.

For a pod:

047f2c095796b37c29dff7bf7c106dd03bbfea00a0d25a2fb4c41a0bcdca9bf0
➜  podman git:(deployments) ✗ ./bin/podman create --pod  mypod alpine top
4ecac58b0ea6453c2a5246987e14de96284c0f1c8edda24d3b098adee3f052a0
➜  podman git:(deployments) ✗ ./bin/podman kube generate --type deployment --replicas 3 mypod
# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-4.5.0-dev
apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: "2023-03-27T21:14:12Z"
  labels:
    app: mypod
  name: mypod-deployment
spec:
  replicas: 3
  selector:
    matchLabels:
      app: mypod
  template:
    metadata:
      creationTimestamp: "2023-03-27T21:14:12Z"
      labels:
        app: mypod
      name: mypod
    spec:
      containers:
      - command:
        - top
        image: docker.io/library/alpine:latest
        name: ecstatichertz
      hostname: mypod```

For a container:
```➜  podman git:(deployments) ✗ ./bin/podman create alpine sleep 100
3e13d4780ed884f86e99eb5bd7335044770aa68c231987bb0da3a5940896458a
➜  podman git:(deployments) ✗ ./bin/podman kube generate --type deployment 3e13d4780ed8 
# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-4.5.0-dev
apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: "2023-03-27T21:15:33Z"
  labels:
    app: upbeatardinghelli-pod
  name: upbeatardinghelli-pod-deployment
spec:
  selector:
    matchLabels:
      app: upbeatardinghelli-pod
  template:
    metadata:
      annotations:
        io.podman.annotations.ulimit: nofile=524288:524288,nproc=127332:127332
      creationTimestamp: "2023-03-27T21:15:33Z"
      labels:
        app: upbeatardinghelli-pod
      name: upbeatardinghelli-pod
    spec:
      containers:
      - command:
        - sleep
        - "100"
        image: docker.io/library/alpine:latest
        name: upbeatardinghelli```

[TomSweeneyRedHat]

All kinds of test unhappiness @umohnani8

[umohnani8]

Tests are mostly green! @containers/podman-maintainers PTAL

[mheon]

Will review tomorrow morning.

@containers/podman-maintainers PTAL

[ashley-cui]

LGTM, thanks for getting this out so fast :)

[vrothberg]

LGTM

Let's wait for a head nod from @edsantiago for the tests.

[edsantiago]

I don't know enough about minikube to review the e2e or minikube tests. One question in system tests, otherwise LGTM

[edsantiago]

Any particular reason not to change this one from Never to null, like the others? Why are you removing this check entirely?

[umohnani8]

restartPolicy will not be a field in the generated yaml for the default case. I don't think null would be a valid value here as it isn't a pointer as the others are.

[umohnani8]

I can open another PR to test that out, but would like to get this one in today before we need to cut the release.

[edsantiago]

No worries, thanks for the explanation. LGTM then.

[umohnani8]

This is ready, please merge when possible @mheon @rhatdan @vrothberg @baude

[rhatdan]

/lgtm