[WIP] Set container oom killed state correctly #17756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
umohnani8
force-pushed
the
memory
branch
6 times, most recently
from
f7dac91 to
73b906b
Compare
|
@umohnani8 Any progress on this one? |
|
@rhatdan yeah I am on it, I have been trying to figure out and reproduce the test failures. |
|
A friendly reminder that this PR had no activity for 30 days. |
Parse the oom file created by conmon when a container is oomkilled and set the oomkilled value to true in the container state. conmon writes the oom file in a persist directory that podman checks now for any oom files for a given container. Signed-off-by: Urvashi Mohnani <[email protected]>
|
Replaced by #21523 |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the oom file created by conmon when a container is oomkilled and set the oomkilled value to true in the container state. conmon writes the oom file in a persist directory that podman checks now for any oom files for a given container.
Partially fixes #13102
Signed-off-by: Urvashi Mohnani [email protected]
Does this PR introduce a user-facing change?