Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log data that we failed to unmarshal #17282

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Log data that we failed to unmarshal #17282

merged 1 commit into from
Jan 31, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jan 30, 2023 •
edited
Loading

This should never happen with a consistent client/server, and we are seeing this show up with some hard-to-diagnose flakes: #16154 .

So, log details about failures. After we find the cause, we might remove this extra logging again.

Does this PR introduce a user-facing change?

Added more (noisy) logging on unexpected remote client data parsing failures, to help debug them.

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2023
@mtrmac mtrmac mentioned this pull request Jan 30, 2023
Open
@edsantiago
Copy link
Member

LGTM, thank you. But you might need [NO NEW TESTS NEEDED].

@mtrmac
Log data that we failed to unmarshal
7c60a78 
This should never happen with a consistent client/server,
and we are seeing this show up with some hard-to-diagnose flakes.

So, log details about failures. After we find the cause, we might remove
this extra logging again.

[NO NEW TESTS NEEDED]

Signed-off-by: Miloslav Trmač <[email protected]>
Luap99
Luap99 reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might bloat the error a lot but I agree that this is better then throwing away the real error message.
LGTM

vrothberg
vrothberg approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ddd8a61 into containers:main Jan 31, 2023
@mtrmac mtrmac deleted the PodRmReport branch January 31, 2023 16:19
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtrmac @edsantiago @vrothberg @Luap99 @openshift-merge-robot