Cirrus: Use versionable IMAGE_SUFFIX #17166
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
cevich
force-pushed
the
versionable_suffixes
branch
from
4a8e8e0 to
274ee0d
Compare
openshift-merge-robot
added
the
needs-rebase
cevich
force-pushed
the
versionable_suffixes
branch
from
274ee0d to
58db4b3
Compare
openshift-merge-robot
removed
the
needs-rebase
cevich
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
LGTM |
Image content hasn't changed much, the biggest thing here is the $IMAGE_SUFFIX value. This new schema is also fully manageable by renovate. Allowing a tag-push to c/automation_images to create image update PRs in all repos automatically. ref: containers/automation_images#247 Also, cleanup a few comments and remove a disused testing task. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
versionable_suffixes
branch
from
58db4b3 to
cf7afed
Compare
|
force-push: Rebased + fixed very minor comment typo. |
| FEDORA_NAME: "fedora-37" ### c20230120t152650z-f37f36u2204 | ||
| FEDORA_AARCH64_NAME: "${FEDORA_NAME}-aarch64" ### c20230120t152650z-f37f36u2204 | ||
| PRIOR_FEDORA_NAME: "fedora-36" ### c20230120t152650z-f37f36u2204 | ||
| #UBUNTU_NAME: "ubuntu-2204" ### c20230120t152650z-f37f36u2204 |
There was a problem hiding this comment.
Are these nasty comments absolutely necessary? I've been reviewing this indirectly via #17305 and the constant changes in comment are distracting.
There was a problem hiding this comment.
Not absolutely necessary. They're there because there's no other (easy) way to associate a IMAGE_SUFFIX value with any of the *_NAME values. In other words, I want maintainers to notice quickly if renovate suggests an incompatible update - i.e. replacing F37 with F38.
However, the current rules treat everything after the - as a "compatibility" value, so (assuming that works) the comment is just a "CYA" value that gets updated with images. Hopefully prompting a maintainer to check - for example, yep, these images still cover "Fedora-36".
Maybe this is just a corner-case we can ignore though?
There was a problem hiding this comment.
I'll endeavor to remove these comments when I come across them. Such as in #17305
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I don't understand what renovatebot has to do with changing an image to f38.... but I'll trust your judgment in this. /lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Image content hasn't changed much, the biggest thing here is the $IMAGE_SUFFIX value. This new schema is also fully manageable by renovate. Allowing a tag-push to c/automation_images to create image update PRs in all repos automatically.
ref: containers/automation_images#247
Also, cleanup a few comments and remove a disused testing task.
Signed-off-by: Chris Evich [email protected]
Does this PR introduce a user-facing change?