Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor in latest containers/(image,ocicrypt) #17125

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Vendor in latest containers/(image,ocicrypt) #17125

merged 1 commit into from
Jan 18, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 16, 2023

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@vrothberg vrothberg added the bloat_approved Approve a PR in which binary file size grows by over 50k label Jan 16, 2023
vrothberg
vrothberg reviewed Jan 16, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Restarted flaked jobs. The bloat comes from sigstore; not much we can do at the moment.

@mheon
Copy link
Member

mheon commented Jan 16, 2023

/lgtm
/hold

Restarted 4 more flakes

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@mheon
Copy link
Member

mheon commented Jan 16, 2023

(At least, I think they're flakes... no matching tests between all the failures)

@vrothberg
Copy link
Member

And two more restarts. Looks like quay.io is having CDN issues.

@vrothberg
Copy link
Member

And more ...

[+1529s] # Error: creating build container: initializing source docker://alpine:latest: reading manifest latest in quay.io/libpod/alpine: received unexpected HTTP status: 502 Bad Gateway

@vrothberg
Copy link
Member

https://status.quay.io/incidents/h993c5nwlnj1 indicates that the Quay team is aware of the CDN issues and that they're working on it. Let's keep an eye on it.

@baude
Copy link
Member

baude commented Jan 17, 2023

how much bloat was added?

@vrothberg
Copy link
Member

how much bloat was added?

Nothing anymore since c/image has already been merged. In comparison to v4.3.1, Podman grew by 1 MB. The sigstore stuff added 3MB IIRC.

@rhatdan
Copy link
Member Author

rhatdan commented Jan 18, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1fe21cb into containers:main Jan 18, 2023
@edsantiago edsantiago mentioned this pull request Jan 25, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhatdan @mheon @vrothberg @baude @openshift-merge-robot