fix flake in kube system test #17108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the loop range from 5 to 20 to make sure we give the service enough time to transition to inactive. Other tests have the same range with 0.5 seconds sleeps, so I expect the new value to be sufficient and consistent. Fixes: containers#17093 Signed-off-by: Valentin Rothberg <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
release-note-none
and removed
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
LGTM
although I think I'd be more comfortable bumping to 10 first. @edsantiago WDYT?
|
I'm fine with the current bump to 20 (i.e., 10 seconds). Remember, that's only a worst-case. Given the rarity of this flake, I expect runs to take only one extra second. A fine price to pay to avoid the flake. /lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This was referenced Jan 25, 2023
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the loop range from 5 to 20 to make sure we give the service enough time to transition to inactive. Other tests have the same range with 0.5 seconds sleeps, so I expect the new value to be sufficient and consistent.
Fixes: #17093
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?
@containers/podman-maintainers PTAL