E2E Test: Play Kube set deadline to connection to avoid hangs #17083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
approved these changes
Jan 11, 2023
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Lint errors |
Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
kube-port-test-set-deadline
branch
from
9f4d0ac to
5b1bdf9
Compare
|
@Luap99 @vrothberg I've changed how I set the deadline so that it will refresh on each timeout error to make sure that one hang does not consume the time of the following retries. PTAL again |
|
@mheon Thanks. The errors triggered me to change the implementation |
|
/lgtm |
|
Not my area of expertise, but am releasing because we have two LGTMs and I want this in stat. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ygal Blum [email protected]
Does this PR introduce a user-facing change?
No