podman-play system test: refactor #17072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #17058; I will rebase once that merges. I just want to see if there are any gotchas I missed in my local testing. |
edsantiago
force-pushed
the
refactor_700
branch
from
fd8f134 to
a0966e4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
edsantiago
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
The kube-play test file was a rat's nest of long complicated yaml strings all differing only slightly. Clean it up, by adding a helper function with optional parameters. The helper is ugly, but the actual test code (the important stuff) is cleaner. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
refactor_700
branch
from
a0966e4 to
6ab8834
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@vrothberg PTAL (low priority) |
vrothberg
reviewed
Jan 13, 2023
|
/lgtm |
|
Thanks, Paul! |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test file was a rat's nest of long complicated yaml strings
all differing only slightly. Clean it up, by adding a helper
function with optional parameters.
Signed-off-by: Ed Santiago [email protected]