[CI:DOCS] Describe copy volume options #16991
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| content when the volume is used on different containers. The **copy** option | ||
| is ignored on bind mounts ,`/HOST-DIR`, and has no effect. |
There was a problem hiding this comment.
The last sentence does not parse. Did you mean something like this?
has no effect on bind mounts or
/HOST-DIR
There was a problem hiding this comment.
Above, we describe the bind mounts based on /HOST-DIR.
--volume, -v=[[SOURCE-VOLUME|HOST-DIR:]CONTAINER-DIR[:OPTIONS]]
Create a bind mount. If -v /HOST-DIR:/CONTAINER-DIR is specified, Podman bind mounts /HOST-DIR from the host into /CONTAINER-DIR in the Podman container. Similarly, -v SOURCE-VOLUME:/CONTAINER-DIR will mount the named volume
from the host into the container. If no such named volume exists, Podman will create one. If no source is given, the volume will be created as an anonymously named volume with a randomly generated name, and will be removed
when the container is removed via the --rm flag or the podman rm --volumes command.
So I am trying to bring users attention back to this.
There was a problem hiding this comment.
Removed since it caused confusion, and adds little value.
test/e2e/run_transient_test.go
Outdated
| @@ -63,7 +63,7 @@ var _ = Describe("Podman run with volumes", func() { | |||
| session.WaitWithDefaultTimeout() | |||
| Expect(session).Should(Exit(0)) | |||
|
|
|||
| // All files should be in permament store, volatile | |||
| // All files should be in permanent store, volatile | |||
There was a problem hiding this comment.
Uh, not actually part of this PR, but is there a missing "not" here ("not volatile")? I'm confused about the difference between this comment and the one on line 52.
There was a problem hiding this comment.
Me too, I just got these by running codespell, since I wanted to make sure I did not add a spelling mistake. I fixes the second one to be not volatile.
| @@ -63,7 +63,7 @@ var _ = Describe("Podman run with volumes", func() { | |||
| session.WaitWithDefaultTimeout() | |||
| Expect(session).Should(Exit(0)) | |||
|
|
|||
| // All files should be in permament store, volatile | |||
| // All files should not be in permanent store, not volatile | |||
There was a problem hiding this comment.
Now I think there's an extra not?
There was a problem hiding this comment.
I think they are both needed.
All files should not be in the permanent store, because the program --rm (removed) them.
Also this is not on a volatile store.
There was a problem hiding this comment.
I'm having a lot of trouble parsing the comment... but that's beyond the scope of this PR.
| @@ -156,6 +156,12 @@ To recursively mount a volume and all of its submounts into a | |||
| used, and submounts of the source directory will not be mounted into the | |||
| <<container|pod>>. | |||
|
|
|||
| Mounting the volume with the **copy** options tells podman to copy content from | |||
There was a problem hiding this comment.
I think this should be option, singular, not plural. LGTM other than this and the "not" question below.
Fixes: containers#16961 Signed-off-by: Daniel J Walsh <[email protected]>
|
Restarted networking flake #16973 |
openshift-ci
bot
added
the
do-not-merge/hold
|
Yes I want to talk to @mheon about this and whether we throw an error if the user attempts to use the |
|
changes LGTM |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Fixes: #16961
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?