Quadlet Container: Add support for EnvironmentFile and EnvironmentHost #16953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygalblum
force-pushed
the
quadlet-container-env
branch
from
63f3e18 to
dd0f189
Compare
|
LGTM |
ygalblum
force-pushed
the
quadlet-container-env
branch
from
f859d30 to
ecd042f
Compare
alexlarsson
reviewed
Jan 3, 2023
ygalblum
force-pushed
the
quadlet-container-env
branch
from
ecd042f to
e3d12d3
Compare
alexlarsson
reviewed
Jan 3, 2023
test/e2e/quadlet/env-file.container
Outdated
| @@ -0,0 +1,9 @@ | |||
| ## assert-podman-final-args localhost/imagename | |||
| ## assert-podman-args --env-file /opt/env/abs-1 --env-file /opt/env/abs-2 | |||
| ## assert-podman-args-regex --env-file /tmp/podman_test.*/quadlet/rel-1 | |||
There was a problem hiding this comment.
Are we sure this is the tmpdir always used? Maybe /.*/podman_test.*/quadlet/rel-1
There was a problem hiding this comment.
You're right. The system tmpdir might not be /tmp. Fixed
Add the new keys to the supported keys list for the Container group Pass the list of EnvironmentFile values while maintaining the order Quadlet e2e test framework: Add support for checking regex in Podman args Add relevant tests Update man Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
quadlet-container-env
branch
from
e3d12d3 to
347d537
Compare
|
lgtm |
|
@containers/podman-maintainers can someone please rerun the flaked test? The failure is not related to the change |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new keys to the supported keys list for the Container group Pass the list of EnvironmentFile values while maintaining the order Quadlet e2e test framework: Add support for checking regex in Podman args Add relevant tests
Update man
Signed-off-by: Ygal Blum [email protected]
Does this PR introduce a user-facing change?
No since Quadlet was not yet released
Resolves: #16730