fix podman system connection - tcp flake

[vrothberg]

The test was only waiting for the port to be ready but that doesn't imply the server being ready to serve requests. Hence, add a loop waiting for the info call to succeed.

Fixes: #16916
Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

None

@containers/podman-maintainers PTAL

[rhatdan]

LGTM

[vrothberg]

Failed tests (1):

• 337 podman system connection - tcp

🤣

[rhatdan]

I guess if this fails over 10 seconds, we might be looking at a different problem.

[vrothberg]

I guess if this fails over 10 seconds, we might be looking at a different problem.

I copy-pasted the loop but should have altered the break-condition. Will update.

[vrothberg]

@containers/podman-maintainers PTAL

[edsantiago]

LGTM with one change request.

For extra credit: if you copypasted this loop from elsewhere, and that elsewhere also has an unquoted question mark, could you also fix that one? I see two instances in 255-auto-update, but those can't possibly be the ones you copied, so I'll take care of fixing those. TIA.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

/lgtm

Changed my mind. I'll fix the questionmark in #16972 instead, so we can get this merged