Stop recording annotations set to false

[rhatdan]

False is the assumed value, and inspect and podman generate kube are being cluttered with a ton of annotations that indicate nothing.

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

podman container inspect and podman kube generate will no longer list default annotations set to false.

[rhatdan]

Gives cleaner looking kube.yaml.

./bin/podman create --name dan --replace fedora echo hi
./bin/podman generate kube dan
# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-4.4.0-dev
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2022-12-19T21:10:01Z"
  labels:
    app: dan-pod
  name: dan-pod
spec:
  containers:
  - command:
    - echo
    - hi
    env:
    - name: QEMU_CPU
      value: max
    image: registry.fedoraproject.org/fedora:latest
    name: dan

Versus

/bin/podman create --name dan --replace fedora echo hi
$ /bin/podman generate kube dan
# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-4.3.1
apiVersion: v1
kind: Pod
metadata:
  annotations:
    io.kubernetes.cri-o.TTY/dan: "false"
    io.podman.annotations.autoremove/dan: "FALSE"
    io.podman.annotations.init/dan: "FALSE"
    io.podman.annotations.privileged/dan: "FALSE"
    io.podman.annotations.publish-all/dan: "FALSE"
  creationTimestamp: "2022-12-19T21:11:51Z"
  labels:
    app: dan-pod
  name: dan-pod
spec:
  automountServiceAccountToken: false
  containers:
  - command:
    - echo
    - hi
    env:
    - name: QEMU_CPU
      value: max
    image: registry.fedoraproject.org/fedora:latest
    name: dan
    securityContext:
      capabilities:
        drop:
        - CAP_MKNOD
        - CAP_NET_RAW
        - CAP_AUDIT_WRITE
  enableServiceLinks: false

[vrothberg]

LGTM
@containers/podman-maintainers PTAL

[giuseppe]

/lgtm
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[umohnani8]

LGTM
/hold cancel