quadlet: Drop ExecStartPre=rm %t/%N.cid #16713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlarsson
changed the title
alexlarsson
force-pushed
the
quadlet-drop-cid-remove
branch
2 times, most recently
from
7dcee69 to
bab3170
Compare
vrothberg
reviewed
Dec 2, 2022
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexlarsson, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Since containers#16394 was merged we now always delete the cid file if --replace=true was specified, so we can avoid this extra command being launched. [NO NEW TESTS NEEDED] Already tested in above PR. Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
quadlet-drop-cid-remove
branch
from
bab3170 to
f3c5b0f
Compare
|
Yeah, forgot to remove the check that looks for the ExecStartPre. |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
1 similar comment
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
riyad
added a commit
to riyad/quadlet-rs
that referenced
this pull request
Jan 1, 2023
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #16394 was merged we now always delete the cid file if --replace=true was specified, so we can avoid this extra command being launched.
Signed-off-by: Alexander Larsson [email protected]