Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: don't install to tmpfiles.d on FreeBSD #16422

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Nov 6, 2022

There is no equivalent equivalent on FreeBSD and this causes lint failures when packaging.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson [email protected]

Does this PR introduce a user-facing change?

None

There is no equivalent equivalent on FreeBSD and this causes lint
failures when packaging.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <[email protected]>
@mheon
Copy link
Member

mheon commented Nov 6, 2022

# Error: initializing source docker://quay.io/libpod/testimage:20221018: can't talk to a V1 container registry

Test failures look registry-related, not due to this PR

@mheon
Copy link
Member

mheon commented Nov 6, 2022

Changes LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 6, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9efa9d8 into containers:main Nov 7, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants