kill: wait for the container #16177
Merged
kill: wait for the container #16177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mheon PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Make sure to wait for the container to exit after kill. While the cleanup process will take care eventually of transitioning the state, we need to give a guarantee to the user to leave the container in the expected state once the (kill) command has finished. The issue could be observed in a flaking test (containers#16142) where `podman rm -f -t0` failed because the preceding `podman kill` left the container in "running" state which ultimately confused the "stop" backend. Note that we should only wait for the container to exit when SIGKILL is being used. Other signals have different semantics. [NO NEW TESTS NEEDED] as I do not know how to reliably reproduce the issue. If containers#16142 stops flaking, we are good. Fixes: containers#16142 Signed-off-by: Valentin Rothberg <[email protected]>
rhatdan
reviewed
Oct 14, 2022
| @@ -82,6 +82,7 @@ var _ = Describe("Podman attach", func() { | |||
| Expect(results.OutputToString()).To(ContainSubstring("test")) | |||
| Expect(podmanTest.NumberOfContainersRunning()).To(Equal(1)) | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
You could have cheated on the test checker. :^)
There was a problem hiding this comment.
:-D this came from looking at test failures
|
LGTM |
|
Doing this in Libpod feels a little wierd, but I can't construct a valid argument to not do it. /lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to wait for the container to exit after kill. While the cleanup process will take care eventually of transitioning the state, we need to give a guarantee to the user to leave the container in the expected state once the (kill) command has finished.
The issue could be observed in a flaking test (#16142) where
podman rm -f -t0failed because the precedingpodman killleft the container in "running" state which ultimately confused the "stop" backend.Note that we should only wait for the container to exit when SIGKILL is being used. Other signals have different semantics.
[NO NEW TESTS NEEDED] as I do not know how to reliably reproduce the issue. If #16142 stops flaking, we are good.
Fixes: #16142
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?