-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix M1 QEMU flags #14563
Fix M1 QEMU flags #14563
Conversation
When calling QEMU, the CPU arch should be host, and highmem should be on, or else the VM start fails. [NO NEW TESTS NEEDED] Signed-off-by: Ashley Cui <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@baude PTAL, should now work with qemu 7.0.0 and with -m > 3072 |
|
Changes LGTM, but @shanesmith 's comment looks très effrayant |
@shanesmith Interesting, i tried in 12.2 and 12.4 and they both work, looks like its just a 12.3 issue.. |
qemu are aware of this issue and are saying that it's a macOS bug in 12.3, they also seem to be happy with 12.4 resolving the issue, no mention of fixing things for 12.3.... this leaves Podman in a bit of a pickle though 😅 |
Here's how Lima has handled it, fwiw |
LGTM |
As mentioned in #14303, the issue seems to be specifically with macOS 12.3 and the Apple M1 Pro chip. |
FWIW, I also see macOS crashing when doing |
@shanesmith @baude @ashley-cui I can now confirm that this fix of |
I also see macOS crashing when doing |
Could not reproduce, I have the same It seems these issues were also dependent on the chip, so for what it's worth I have a MacBook Pro (14-inch, 2021) which has an Apple M1 Pro chip. |
Thanks, I reinstalled qemu by brew, deleted vm, reinited it and problem is gone! |
That not after MacBook Pro (13-inch, M1, 2020) |
When calling QEMU, the CPU arch should be host, and highmem should be on, or else the VM start fails.
[NO NEW TESTS NEEDED]
Signed-off-by: Ashley Cui [email protected]
Fixes: #14303
Does this PR introduce a user-facing change?