[macos: podman-machine] look for firmware (edk2-code-fd) based on the path of qemu binary #14324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows users to use a qemu installation that is not in the default /usr/local/bin location a user can configure engine.helper_binaries_dir key or update PATH to include the installation location to find the qemu binary [NO NEW TESTS NEEDED] Signed-off-by: Anjan Nath <[email protected]>
|
@baude @ashley-cui PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rhatdan
reviewed
Jun 13, 2022
| @@ -45,6 +63,7 @@ func getOvmfDir(imagePath, vmName string) string { | |||
| */ | |||
| func getEdk2CodeFd(name string) string { | |||
| dirs := []string{ | |||
| getEdk2CodeFdPathFromQemuBinaryPath(), | |||
There was a problem hiding this comment.
Shouldn't this only be done if the output is NOT ""?
There was a problem hiding this comment.
Should be OK without checking if it's "" empty string, as in the code below at L72 its forming the full path and checking if the file exists at the path before returning.
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows users to use a qemu installation that is
not in the default /usr/local/bin location
a user can configure engine.helper_binaries_dir key
or update PATH to include the installation location
to find the qemu binary
Signed-off-by: Anjan Nath [email protected]
Does this PR introduce a user-facing change?