-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed permission of .ubuntu_prepare.sh to 755 #14234
Changed permission of .ubuntu_prepare.sh to 755 #14234
Conversation
/assign @Luap99 |
Please add [NO NEW TESTS NEEDED] github message and repush. Does this fix something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message does not match the change, the file is changed to 755 but your commit message states 775. IMO 755 is correct so please update the commit message.
[NO NEW TESTS NEEDED] Signed-off-by: Stefin <[email protected]>
22c7dab
to
c058b82
Compare
@Luap99 Sorry my bad! |
@stefins you need to add |
@TomSweeneyRedHat I already did it |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, stefins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Signed-off-by: Stefin [email protected]
Does this PR introduce a user-facing change?