Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed permission of .ubuntu_prepare.sh to 755 #14234

Merged
merged 1 commit into from
May 17, 2022

Conversation

stefins
Copy link
Contributor

@stefins stefins commented May 13, 2022

Signed-off-by: Stefin [email protected]

Does this PR introduce a user-facing change?

None

@stefins
Copy link
Contributor Author

stefins commented May 13, 2022

/assign @Luap99

@rhatdan
Copy link
Member

rhatdan commented May 13, 2022

Please add [NO NEW TESTS NEEDED] github message and repush.

Does this fix something?

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message does not match the change, the file is changed to 755 but your commit message states 775. IMO 755 is correct so please update the commit message.

[NO NEW TESTS NEEDED]

Signed-off-by: Stefin <[email protected]>
@stefins stefins force-pushed the change-permission branch from 22c7dab to c058b82 Compare May 13, 2022 13:40
@stefins
Copy link
Contributor Author

stefins commented May 13, 2022

@Luap99 Sorry my bad!

@stefins stefins changed the title Changed permission of .ubuntu_prepare.sh to 775 Changed permission of .ubuntu_prepare.sh to 755 May 13, 2022
@TomSweeneyRedHat
Copy link
Member

@stefins you need to add [NO NEW TESTS NEEDED] to your commit description and push again.
Changes LGTM otherwise

@stefins
Copy link
Contributor Author

stefins commented May 17, 2022

@TomSweeneyRedHat I already did it

@rhatdan
Copy link
Member

rhatdan commented May 17, 2022

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, stefins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022
@edsantiago
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9915b8f into containers:main May 17, 2022
@stefins stefins deleted the change-permission branch May 18, 2022 17:53
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants